[Testcontainers] move integration test to internal #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I like the approach of creating a new module for the ITs, so that the indirect deps are not pushed to clients. I did exactly the same for the compose module for testcontainers-go, to avoid. pushing all compose deps to all users. Cheers! |
Anaethelion
added a commit
that referenced
this pull request
Jun 4, 2024
* feat: use testcontainers-go for the integration tests * chore: bump to latest release * chore: wrap the ES container into a struct * adapt github action to testcontainers * use the same container for all the integration subtests * use testcontainers for esapi integration tests * use testcontainers for esutil integration tests * update testcontainers-go dependency to main branch as a wip * move custom transport test and insecure default to insecure integration part * update to latest testcontainers-go 0.31.0 * reorder imports * move integration test to internal package with testcontainers * adapt makefile to use the new internal/testing package * fix bad version transport regression * update examples dependencies * reinstate server launch for example testing --------- Co-authored-by: Manuel de la Peña <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 4, 2024
* feat: use testcontainers-go for the integration tests (#824) * feat: use testcontainers-go for the integration tests * chore: bump to latest release * chore: wrap the ES container into a struct * [Testcontainers] move integration test to internal (#855) * feat: use testcontainers-go for the integration tests * chore: bump to latest release * chore: wrap the ES container into a struct * adapt github action to testcontainers * use the same container for all the integration subtests * use testcontainers for esapi integration tests * use testcontainers for esutil integration tests * update testcontainers-go dependency to main branch as a wip * move custom transport test and insecure default to insecure integration part * update to latest testcontainers-go 0.31.0 * reorder imports * move integration test to internal package with testcontainers * adapt makefile to use the new internal/testing package * fix bad version transport regression * update examples dependencies * reinstate server launch for example testing --------- Co-authored-by: Manuel de la Peña <[email protected]> --------- Co-authored-by: Manuel de la Peña <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #824
This moves over the integration test into an internal package to avoid importing
testcontainers-goand dependencies into the main library.